Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for assets #388

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Use HTTPS for assets #388

merged 1 commit into from
Dec 9, 2021

Conversation

HAstaShakiba
Copy link
Contributor

No description provided.

@shalvah
Copy link
Contributor

shalvah commented Dec 9, 2021

I see you're a first-time contributor. Thank you for the PR👏

Unfortunately, this isn't exactly the problem/solution. Omitting the protocol tells the browser to use whatever protocol the page is on (see this SO answer). So, if your page is on http, the browser will fetch Lodash via http, and same for https.

@shalvah
Copy link
Contributor

shalvah commented Dec 9, 2021

On second thought...this means if you're viewing the docs by opening the file locally in your browser, the protocol will be file://, which means the browser will try to fetch file://lodash, which won't work. So maybe you're right, we should switch to https. No harm requesting HTTPS from a HTTP page.

@shalvah shalvah changed the title fix link in defualt html file Use HTTPS for assets Dec 9, 2021
@shalvah shalvah merged commit 936b5cf into knuckleswtf:master Dec 9, 2021
@shalvah
Copy link
Contributor

shalvah commented Dec 9, 2021

Released in 3.19.1 👍

@HAstaShakiba
Copy link
Contributor Author

Thanks for the great package

@HAstaShakiba HAstaShakiba deleted the patch-1 branch December 9, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants