Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to define custom names for languages in config, by using the array key #382

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add ability to define custom names for languages in config, by using the array key #382

merged 1 commit into from
Dec 7, 2021

Conversation

robbieaverill
Copy link
Contributor

@robbieaverill robbieaverill commented Dec 7, 2021 •
edited
Loading

This allows you to define custom language names which will be used in the output docs language switcher buttons, e.g.:

# File: config/scribe.php
'example_languages' => [
    'bash',
    'javascript',
    'TS' => 'typescript',
],

Also fixes the language switcher on mobile which was broken (wouldn't switch language and would always send you to the top of the page).

@robbieaverill robbieaverill mentioned this pull request Dec 7, 2021
Merged
@robbieaverill robbieaverill force-pushed the feature/naming-languages branch from 76ac9f1 to 45c25c9 Compare December 7, 2021 00:39
@shalvah shalvah merged commit 997f30e into knuckleswtf:master Dec 7, 2021
@robbieaverill robbieaverill deleted the feature/naming-languages branch December 7, 2021 06:44
@shalvah
Copy link
Contributor

shalvah commented Dec 8, 2021

3.19.0 '👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbieaverill @shalvah