Merge pull request #318 from Redtama/allow-body-params-on-get-requests

Removed the check that prevented GET endpoint handlers from supportin…
knuckleswtf · Sep 9, 2021 · f8fe1cb · f8fe1cb
2 parents 2ff7c29 + abf6ecc
commit f8fe1cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Extracting/Extractor.php b/src/Extracting/Extractor.php
@@ -161,9 +161,6 @@ protected function fetchQueryParameters(ExtractedEndpointData $endpointData, arr
 
     protected function fetchBodyParameters(ExtractedEndpointData $endpointData, array $rulesToApply): void
     {
-        if (in_array('GET', $endpointData->httpMethods)) {
-            return;
-        }
         $this->iterateThroughStrategies('bodyParameters', $endpointData, $rulesToApply, function ($results) use ($endpointData) {
             foreach ($results as $key => $item) {
                 if (empty($item['name'])) {

diff --git a/tests/Unit/ExtractorPluginSystemTest.php b/tests/Unit/ExtractorPluginSystemTest.php
@@ -65,6 +65,7 @@ public function responses_from_different_strategies_get_added()
     {
         $config = [
             'strategies' => [
+                'bodyParameters' => [],
                 'responses' => [DummyResponseStrategy200::class, DummyResponseStrategy400::class],
             ],
         ];
@@ -94,6 +95,7 @@ public function combines_results_from_different_strategies_in_same_stage()
         $config = [
             'strategies' => [
                 'metadata' => [PartialDummyMetadataStrategy1::class, PartialDummyMetadataStrategy2::class],
+                'bodyParameters' => [],
                 'responses' => [],
             ],
         ];
@@ -117,6 +119,7 @@ public function missing_metadata_is_filled_in()
         $config = [
             'strategies' => [
                 'metadata' => [PartialDummyMetadataStrategy2::class],
+                'bodyParameters' => [],
                 'responses' => [],
             ],
         ];
@@ -140,6 +143,7 @@ public function overwrites_metadata_from_previous_strategies_in_same_stage()
         $config = [
             'strategies' => [
                 'metadata' => [NotDummyMetadataStrategy::class, PartialDummyMetadataStrategy1::class],
+                'bodyParameters' => [],
                 'responses' => [],
             ],
         ];