Merge pull request #456 from michaeljennings/master

Update grouped endpoint classes to be easier to extend
knuckleswtf · Mar 31, 2022 · 961a873 · 961a873
2 parents 4e3d72f + 4240569
commit 961a873
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 5 deletions.
diff --git a/src/GroupedEndpoints/GroupedEndpointsFactory.php b/src/GroupedEndpoints/GroupedEndpointsFactory.php
@@ -11,13 +11,26 @@ class GroupedEndpointsFactory
     public function make(GenerateDocumentation $command, RouteMatcherInterface $routeMatcher): GroupedEndpointsContract
     {
         if ($command->isForcing()) {
-            return new GroupedEndpointsFromApp($command, $routeMatcher, false);
+            return $this->makeGroupedEndpointsFromApp($command, $routeMatcher, false);
         }
 
         if ($command->shouldExtract()) {
-            return new GroupedEndpointsFromApp($command, $routeMatcher, true);
+            return $this->makeGroupedEndpointsFromApp($command, $routeMatcher, true);
         }
 
-        return new GroupedEndpointsFromCamelDir;
+        return $this->makeGroupedEndpointsFromCamelDir();
+    }
+
+    protected function makeGroupedEndpointsFromApp(
+        GenerateDocumentation $command,
+        RouteMatcherInterface $routeMatcher,
+        bool $preserveUserChanges
+    ): GroupedEndpointsFromApp {
+        return new GroupedEndpointsFromApp($command, $routeMatcher, $preserveUserChanges);
+    }
+
+    protected function makeGroupedEndpointsFromCamelDir(): GroupedEndpointsFromCamelDir
+    {
+        return new GroupedEndpointsFromCamelDir();
     }
 }
diff --git a/src/GroupedEndpoints/GroupedEndpointsFromApp.php b/src/GroupedEndpoints/GroupedEndpointsFromApp.php
@@ -90,7 +90,8 @@ protected function extractEndpointsInfoAndWriteToDisk(RouteMatcherInterface $rou
      */
     private function extractEndpointsInfoFromLaravelApp(array $matches, array $cachedEndpoints, array $latestEndpointsData, array $groups): array
     {
-        $generator = new Extractor($this->docConfig);
+        $generator = $this->makeExtractor();
+
         $parsedEndpoints = [];
 
         foreach ($matches as $routeItem) {
@@ -274,7 +275,23 @@ private function isRouteHiddenFromDocumentation(array $routeControllerAndMethod)
 
     protected function extractAndWriteApiDetailsToDisk(): void
     {
-        $apiDetails = new ApiDetails($this->docConfig, !$this->command->option('force'));
+        $apiDetails = $this->makeApiDetails();
+
         $apiDetails->writeMarkdownFiles();
     }
+
+    protected function makeApiDetails(): ApiDetails
+    {
+        return new ApiDetails($this->docConfig, !$this->command->option('force'));
+    }
+
+    /**
+     * Make a new extractor.
+     *
+     * @return Extractor
+     */
+    protected function makeExtractor(): Extractor
+    {
+        return new Extractor($this->docConfig);
+    }
 }