Skip to content

Commit

Permalink
Smarter description (singular v plural)
Browse files Browse the repository at this point in the history
  • Loading branch information
shalvah committed Nov 18, 2022
1 parent e9bd84f commit 0b9473b
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/Extracting/ParsesValidationRules.php
Original file line number Diff line number Diff line change
Expand Up @@ -669,10 +669,14 @@ protected function getDescription(string $rule, array $arguments = [], $baseType
$description = str_replace($placeholder, $argument, $description);
}

// FOr rules that validate subfields
$description = str_replace("The :attribute field", "This field", $description);

return str_replace("The value must", "Must", str_replace(":attribute", "value", $description));
// For rules that validate subfields
$description = str_replace("The :attribute field ", "This field ", $description);

return str_replace(
[" :attribute ", "The value must ", " 1 characters", " 1 digits", " 1 kilobytes"],
[" value ", "Must ", " 1 character", " 1 digit", " 1 kilobyte"],
$description
);
}

private function getLaravelValidationBaseTypeMapping(string $parameterType): string
Expand Down

0 comments on commit 0b9473b

Please sign in to comment.