Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more chars in refs #353

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

tocic
Copy link
Contributor

@tocic tocic commented Aug 25, 2024

All currently existing refs in cppquiz are supported, 297 out of 20945 in C++23 index are unsupported (160 containing an asterisk, 131 ending in a right parenthesis, 4 ending in a quotation mark, 2 ending in an exclamation mark).

Fixes #344.

@tocic tocic force-pushed the feat/more_chars_in_refs branch 3 times, most recently from f4d638f to f055f32 Compare August 27, 2024 05:23
@tocic tocic marked this pull request as ready for review August 27, 2024 05:24
@tocic tocic force-pushed the feat/more_chars_in_refs branch 2 times, most recently from 09b8962 to fb4feae Compare August 28, 2024 03:44
Copy link
Owner

@knatten knatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to submit this review after adding the comments some weeks ago :(

@knatten knatten self-assigned this Sep 15, 2024
Copy link
Owner

@knatten knatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks a lot! Please rebase on master, then I can merge it.

All currently existing refs in cppquiz are supported, 297 out of 20945
in C++23 index are unsupported (160 containing an asterisk, 131 ending
in a right parenthesis, 4 ending in a quotation mark, 2 ending in
an exclamation mark).

Fixes knatten#344.
@tocic tocic force-pushed the feat/more_chars_in_refs branch from fb4feae to 0eb7fbc Compare September 16, 2024 03:47
@knatten knatten merged commit ca67f87 into knatten:master Sep 16, 2024
7 checks passed
@knatten
Copy link
Owner

knatten commented Sep 16, 2024

And it's deployed! Thanks for fixing this.

@tocic tocic deleted the feat/more_chars_in_refs branch September 17, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support symbol '-' in standard_ref()
2 participants