Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Search results include advertisements #23

Closed
rgregg opened this issue Apr 2, 2019 · 5 comments
Closed

Search results include advertisements #23

rgregg opened this issue Apr 2, 2019 · 5 comments
Assignees
Labels
kind/enhancement kind/question Further information is requested priority/1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Comments

@rgregg
Copy link
Contributor

rgregg commented Apr 2, 2019

When we do a search, ads for related terms appear on the search page. We should be able to opt out of those.

https://www.knative.dev/search/?q=testing

@RichieEscarez
Copy link
Contributor

Blocking item: knative specific @gmail.com account

@RichieEscarez RichieEscarez added kind/enhancement kind/question Further information is requested priority/1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2019
@rgregg
Copy link
Contributor Author

rgregg commented Apr 11, 2019

Does the email address get published anywhere? We should probably create a knative-website Google Group that's shared among the WG leads for this purpose.

@RichieEscarez
Copy link
Contributor

I suppose the address could be published but the idea is to create a single/separate account that we can tie the Custom Search Engine account to (and I suppose we would also tie it to the Analytics account).

@RichieEscarez
Copy link
Contributor

RichieEscarez commented Apr 11, 2019

I tried to create a new gmail account, specifically "knative@gmail.com" but it already exists and I'm wondering if we own that (before I try creating another account)?

Something like a Google Group address wont work because it still gets tied to a specific email account (you can assign owners but you need to sign in with a user account to create the group in the first place).

If we dont know who owns knative@gmail.com, do any of these addresses work? Any other suggestions?

  • knative-website@
  • knative.dev@

@RichieEscarez
Copy link
Contributor

Fixed: #34

RichieEscarez pushed a commit to RichieEscarez/website that referenced this issue Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement kind/question Further information is requested priority/1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

7 participants