Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autoscale for Istio gateways in E2E tests #5064

Merged

Conversation

JRBANCEL
Copy link
Contributor

@JRBANCEL JRBANCEL commented Aug 5, 2019

Historically, the Istio Ingress Gateway replica count was fixed to 1 because there was no mechanism to figure out if a replica had been updated to the latest configuration. The workaround was to way until the 404 disappear and assume that at that point the replica had the desired configuration. This only work when there is a single replica.

#4734 addresses this. This is the logical next step after #4976.

Proposed Changes

  • Enable HPA for Istio gateways in E2E tests

Next

  • Reduce Istio's gateways resources quotas

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2019
@JRBANCEL
Copy link
Contributor Author

JRBANCEL commented Aug 5, 2019

/test pull-knative-serving-istio-1.1-mesh
/test pull-knative-serving-istio-1.1-no-mesh
/test pull-knative-serving-istio-1.2-mesh
/test pull-knative-serving-istio-1.2-no-mesh

@JRBANCEL
Copy link
Contributor Author

JRBANCEL commented Aug 5, 2019

TestTargetBurstCapacity failed and is known to be flacky.
/retest

@tcnghia
Copy link
Contributor

tcnghia commented Aug 6, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JRBANCEL, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@knative-prow-robot knative-prow-robot merged commit 26228c5 into knative:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants