Introduce new knob for configuring burst capacity. #4433
Conversation
Introduce the new config-map setting for the target burst capacity. For the starters it is a global setting, but we probably should at some point permi per service overrides as annotations (;-)). Default of 0.
There was a problem hiding this comment.
@vagababov: 0 warnings.
In response to this:
Introduce the new config-map setting for the target burst capacity.
For the starters it is a global setting, but we probably should at some point permi
per service overrides as annotations (;-))./lint
Proposed Changes
- new config value to configure burst capacity
- tests
/assign @markusthoemmes @mattmoor
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on pkg/.
|
|
/lgtm With stuff like this where were adding a config option and docs do we have a way to make sure users arent given this before it actually works? At a minimum we shouldn't merge this until after 0.7 I think. |
|
/hold due to what I asked above re: not merging until 0.7 |
|
Since it's not working ordering doesn't really matter. But we can stack them all for Tuesday. |
|
/retest |
|
/lgtm Will approve post-cut tomorrow. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Introduce the new config-map setting for the target burst capacity. For the starters it is a global setting, but we probably should at some point permi per service overrides as annotations (;-)). Default of 0.
Introduce the new config-map setting for the target burst capacity.
For the starters it is a global setting, but we probably should at some point permi
per service overrides as annotations (;-)).
/lint
For #1846 #1409
Proposed Changes
/assign @markusthoemmes @mattmoor