Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global resync test for SKS #3900

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Add global resync test for SKS #3900

merged 1 commit into from
Apr 26, 2019

Conversation

vagababov
Copy link
Contributor

/lint

Paying off my eng-debt.
This is a global resync test for the SKS, which verifies that we update all the necessary SKSs whenever the activator endpoints change.

Part of #1997

/cc @mattmoor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 25, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2019
knative-prow-robot
knative-prow-robot reviewed Apr 25, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

/lint

Paying off my eng-debt.
This is a global resync test for the SKS, which verifies that we update all the necessary SKSs whenever the activator endpoints change.

Part of #1997

/cc @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Apr 25, 2019
@vagababov
Copy link
Contributor Author

ready for another view

@vagababov vagababov force-pushed the 1997-global-resync-for-realzis branch from e2021db to 71374d9 Compare April 26, 2019 05:40
mattmoor
mattmoor reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d1eea7e into knative:master Apr 26, 2019
@vagababov vagababov deleted the 1997-global-resync-for-realzis branch June 7, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vagababov @knative-prow-robot @mattmoor @googlebot