Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated code from revision, etc dealing with services #3888

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

vagababov
Copy link
Contributor

/lint
part of #1997

Proposed Changes

  • Deletes the code that is no longer used.
  • Moves some constants around

/cc @mattmoor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 24, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/autoscale area/networking size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

/lint
part of #1997

Proposed Changes

  • Deletes the code that is no longer used.
  • Moves some constants around

/cc @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Red lines are the best lines. 🎉

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/autoscaling/v1alpha1/pa_validation.go 75.6% 75.0% -0.6
pkg/reconciler/autoscaling/hpa/hpa.go Do not exist 93.8%
pkg/reconciler/autoscaling/kpa/kpa.go Do not exist 91.4%
pkg/reconciler/autoscaling/kpa/resources/service.go Do not exist 100.0%
pkg/reconciler/revision/resources/kpa.go Do not exist 100.0%
pkg/reconciler/revision/resources/names/names.go Do not exist 100.0%
pkg/reconciler/route/resources/service.go Do not exist 100.0%

@knative-prow-robot knative-prow-robot merged commit 37ade0b into knative:master Apr 24, 2019
@vagababov vagababov deleted the 1997-delete-rev-service branch June 7, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants