Fix the problem where old PAs go into unknown state. #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origianally (even before my changes) the old updatePAStatus method would change the status of the PA to unknown, even if it's inactive. The reason for that is that after restart for an inactive revision the desired scale is always -1. Now, this was not much of a problem in the previous life, since when activated the desired scale would become 1 and everything would unfold as desired. But in this new brave world, this causes SKS to reconcile to serve more, which removes the activator endpoints from the public k8s service and prohibits our future endeavours like positive handoff. The change is simple: basically ignore want==-1 scale events, when changing status. This works because: if want == -1 and we're inactive => stay inactive if want == -1 and we're active => stay active if want == -1 and we're activating => continue activating.
|
The following is the coverage report on pkg/.
|
|
/test pull-knative-serving-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origianally (even before my changes) the old updatePAStatus
method would change the status of the PA to unknown, even if it's
inactive. The reason for that is that after restart for an inactive
revision the desired scale is always -1.
Now, this was not much of a problem in the previous life, since when
activated the desired scale would become 1 and everything would unfold
as desired. But in this new brave world, this causes SKS to reconcile to
serve more, which removes the activator endpoints from the public k8s
service and prohibits our future endeavours like positive handoff.
The change is simple: basically ignore want==-1 scale events, when
changing status. This works because:
if want == -1 and we're inactive => stay inactive
if want == -1 and we're active => stay active
if want == -1 and we're activating => continue activating.
/cc @mattmoor
#1997