Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the change that removed the public service creation in SKS #3786

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Revert the change that removed the public service creation in SKS #3786

merged 5 commits into from
Apr 18, 2019

Conversation

vagababov
Copy link
Contributor

Bring back public service and manual endpoint reconciliation
This is part of the #1997.

/lint

Proposed Changes

  • revert changes

/cc @mattmoor

@vagababov
Revert the change that removed the public service creation in SKS
ecacdec 
Bring back public service and manual endpoint reconciliation
This is part of the knative#1997.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 17, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2019
knative-prow-robot
knative-prow-robot reviewed Apr 17, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

Bring back public service and manual endpoint reconciliation
This is part of the #1997.

/lint

Proposed Changes

  • revert changes

/cc @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
mattmoor
mattmoor reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@vagababov
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

@vagababov vagababov closed this Apr 17, 2019
@vagababov vagababov reopened this Apr 17, 2019
@vagababov
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/serverlessservice/serverlessservice.go Do not exist 88.3%

mattmoor
mattmoor reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9d035c4 into knative:master Apr 18, 2019
@vagababov vagababov deleted the 1997-sks-back branch June 7, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vagababov @knative-metrics-robot @knative-prow-robot @mattmoor @googlebot