Reduce a deployments selector to only match the revision uid #2818
Conversation
Prior the selector criteria would include all the revision's labels. This would cause reconciliation of a revision's deployment to fail when a revision label was added/removed.
|
/assign @mattmoor |
There was a problem hiding this comment.
@dprotaso: 0 warnings.
In response to this:
Prior the selector criteria would include all the revision's labels.
This would cause reconciliation of a revision's deployment to fail
when a revision label was added/removed.Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on pkg/.
|
|
/test pull-knative-serving-integration-tests |
|
/label serving-0.3 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-knative-serving-unit-tests |
Prior the selector criteria would include all the revision's labels.
This would cause reconciliation of a revision's deployment to fail
when a revision label was added/removed.
Release Note