Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaulting for all GRPC probe types #14773

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add defaulting for all GRPC probe types #14773

merged 3 commits into from
Jan 11, 2024

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Jan 10, 2024 •
edited
Loading

Fixes #14771

Proposed Changes

  • Adds defaulting for the string in GRPC probes for all probe types
  • Adds an E2E readiness test with a GRPC probe

@ReToCode ReToCode requested a review from skonto January 10, 2024 12:49
@knative-prow knative-prow bot added area/API API objects and controllers area/autoscale size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/networking labels Jan 10, 2024
@knative-prow knative-prow bot requested review from jsanin-vmw and KauzClay January 10, 2024 12:50
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (b6552f9) 86.01% compared to head (5bbf3d6) 85.95%.
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/apis/serving/v1/revision_defaults.go 30.76% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14773      +/-   ##
==========================================
- Coverage   86.01%   85.95%   -0.06%     
==========================================
  Files         197      197              
  Lines       14937    14945       +8     
==========================================
- Hits        12848    12846       -2     
- Misses       1778     1785       +7     
- Partials      311      314       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

/assign @skonto

@knative-prow knative-prow bot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2024
@ReToCode
Copy link
Member Author

@skonto I also added an E2E test as discussed, can you please take another look?

/assign @dprotaso

@ReToCode
Copy link
Member Author

/retest

@skonto
Copy link
Contributor

skonto commented Jan 11, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@skonto skonto added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@skonto
Copy link
Contributor

skonto commented Jan 11, 2024

/lgtm
/hold for tests

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 11, 2024
@skonto
Copy link
Contributor

skonto commented Jan 11, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@knative-prow knative-prow bot merged commit 7feb050 into knative:main Jan 11, 2024
48 checks passed
ReToCode added a commit to ReToCode/serving that referenced this pull request Jan 12, 2024
@ReToCode
Add defaulting for all GRPC probe types (knative#14773)
c8dd660 
* Add defaulting for all GRPC probe types

* Add an E2E readiness test with GRPC probes

* Rename function

(cherry picked from commit 7feb050)
ReToCode added a commit to ReToCode/serving that referenced this pull request Jan 12, 2024
@ReToCode
Add defaulting for all GRPC probe types (knative#14773)
3b77333 
* Add defaulting for all GRPC probe types

* Add an E2E readiness test with GRPC probes

* Rename function

(cherry picked from commit 7feb050)
This was referenced Jan 12, 2024
Merged
Merged
@dprotaso
Copy link
Member

Should we cherry pick to older release branches?

openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jan 18, 2024
@ReToCode
Add defaulting for all GRPC probe types (knative#14773) (#587)
c19ffad 
* Add defaulting for all GRPC probe types

* Add an E2E readiness test with GRPC probes

* Rename function

(cherry picked from commit 7feb050)
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jan 22, 2024
@ReToCode
[RELEASE-1.11] Add defaulting for all GRPC probe types (#586)
b333c05 
* Add defaulting for all GRPC probe types (knative#14773)

* Add defaulting for all GRPC probe types

* Add an E2E readiness test with GRPC probes

* Rename function

(cherry picked from commit 7feb050)

* Fix build issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skonto skonto skonto left review comments

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

@KauzClay KauzClay Awaiting requested review from KauzClay

Assignees

@dprotaso dprotaso

@skonto skonto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GRPC probes service field should have defaulting
3 participants
@ReToCode @skonto @dprotaso