Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version in kind-e2e tests to v1.18 #13140

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

psschwei
Copy link
Contributor

Signed-off-by: Paul S. Schweigert paulschw@us.ibm.com

We bumped the min go version in knative/pkg#2548, so we should probably build using it when running the kind e2e tests

Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #13140 (dde34af) into main (dc552e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13140   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files         196      196           
  Lines       14410    14410           
=======================================
  Hits        12506    12506           
  Misses       1609     1609           
  Partials      295      295           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc552e5...dde34af. Read the comment docs.

@nak3
Copy link
Contributor

nak3 commented Jul 22, 2022

/lgtm
/approve

Thank you. KinD with contour sometimes fails but it seems not related to this PR.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d1f8e8d into knative:main Jul 22, 2022
@psschwei psschwei deleted the bump-kind-go branch August 10, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants