-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.3] Fix tag to digest resolution (bump ggcr) #12835
[release-1.3] Fix tag to digest resolution (bump ggcr) #12835
Conversation
I forgot to bump ggcr's sub package in the prior release github.com/google/go-containerregistry/pkg/authn/k8schain
whoops - picked the wrong base branch |
@dprotaso: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov Report
@@ Coverage Diff @@
## release-1.3 #12835 +/- ##
===============================================
+ Coverage 87.27% 87.29% +0.02%
===============================================
Files 196 195 -1
Lines 9750 9727 -23
===============================================
- Hits 8509 8491 -18
+ Misses 954 952 -2
+ Partials 287 284 -3
Continue to review full report at Codecov.
|
note: since I targeted the wrong base the but proper prow jobs are running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
||
replace ( | ||
k8s.io/api => k8s.io/api v0.22.5 | ||
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.22.5 | ||
k8s.io/apimachinery => k8s.io/apimachinery v0.22.5 | ||
k8s.io/client-go => k8s.io/client-go v0.22.5 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason for using a previous minor k8s version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind, I got it now.
Part of #12761
Proposed Changes
github.com/google/go-containerregistry/pkg/authn/k8schain
so the fix wasn't in the patch releaseRelease Note