Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] Fix tag to digest resolution (bump ggcr) #12835

Merged

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Apr 8, 2022

Part of #12761

Proposed Changes

  • Forgot to bump github.com/google/go-containerregistry/pkg/authn/k8schain so the fix wasn't in the patch release

Release Note

Fix tag to digest resolution when using imagePullSecrets

I forgot to bump ggcr's sub package in the prior release

github.com/google/go-containerregistry/pkg/authn/k8schain
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2022
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2022
@dprotaso dprotaso changed the base branch from main to release-1.3 April 8, 2022 13:48
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2022
@dprotaso
Copy link
Member Author

dprotaso commented Apr 8, 2022

whoops - picked the wrong base branch

@dprotaso dprotaso closed this Apr 8, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 8, 2022

@dprotaso: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_serving_main 924381b link true /test build-tests_serving_main
upgrade-tests_serving_main 924381b link true /test upgrade-tests_serving_main
unit-tests_serving_main 924381b link true /test unit-tests_serving_main
istio-latest-no-mesh_serving_main 924381b link true /test istio-latest-no-mesh_serving_main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dprotaso dprotaso reopened this Apr 8, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psschwei
Copy link
Contributor

psschwei commented Apr 8, 2022

/retest

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #12835 (924381b) into release-1.3 (f52ae88) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release-1.3   #12835      +/-   ##
===============================================
+ Coverage        87.27%   87.29%   +0.02%     
===============================================
  Files              196      195       -1     
  Lines             9750     9727      -23     
===============================================
- Hits              8509     8491      -18     
+ Misses             954      952       -2     
+ Partials           287      284       -3     
Impacted Files Coverage Δ
cmd/activator/request_log.go
pkg/reconciler/configuration/configuration.go 86.15% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f52ae88...924381b. Read the comment docs.

@dprotaso
Copy link
Member Author

dprotaso commented Apr 8, 2022

note: since I targeted the wrong base the istio-latest-no-mesh-tls_serving_main jobs aren't going to re-run

but proper prow jobs are running build-tests_serving_release-1.3

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@knative-prow knative-prow bot merged commit 4126928 into knative:release-1.3 Apr 8, 2022
@dprotaso dprotaso deleted the release13-fix-tag-to-digest branch April 8, 2022 14:45
Comment on lines +47 to +53

replace (
k8s.io/api => k8s.io/api v0.22.5
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.22.5
k8s.io/apimachinery => k8s.io/apimachinery v0.22.5
k8s.io/client-go => k8s.io/client-go v0.22.5
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason for using a previous minor k8s version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, I got it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants