Drop dynamic wrapper injection code generation #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
==========================================
- Coverage 81.53% 81.50% -0.03%
==========================================
Files 163 163
Lines 10018 10018
==========================================
- Hits 8168 8165 -3
- Misses 1606 1608 +2
- Partials 244 245 +1
☔ View full report in Codecov by Sentry. |
|
/assign @pierDipi |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 18, 2023
creydr
added a commit
to creydr/knative-eventing-istio
that referenced
this pull request
Jun 19, 2023
…ent_expansion.go Codegen support for informers and clients that use the dynamic.Client interface was dropped in knative/pkg#2742.
knative-prow bot
pushed a commit
to knative-extensions/eventing-istio
that referenced
this pull request
Jun 21, 2023
* Update dependencies to latest * Remove dependency to knative.dev/pkg/client/injection/kube/client/client_expansion.go Codegen support for informers and clients that use the dynamic.Client interface was dropped in knative/pkg#2742. * Run update-codegen.sh * Regenerate pkg/client/injection/kube * Update 3rd party eventing-latest * Install cert-manager for e2e tests Some eventing e2e tests are using eventhub.WithTLS(), which creates certificates and thus requires cert-manager in their setup. Even this tests might be skipped, as this is run in their environment setup, theses test fail if cert-manager is not installed. Therefor we need to install cert-manager for the e2e tests. * Update eventing core dependency * Fix shell lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2739
This removes the codegen logic that generates informers and clients that use the dynamic.Client underneath. These aren't being used anywhere.