Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Injection: Generation of informers backed by a dynamic client is opt-in #2740

Closed
wants to merge 5 commits into from

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 16, 2023

Fixes: #2739

A new flag now exists -include-dynamic-informers to produce the prior dynamic based informers

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2023
@knative-prow
Copy link

knative-prow bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from pradnyavmw and skonto May 16, 2023 14:37
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprotaso
Copy link
Member Author

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@dprotaso
Copy link
Member Author

Seems like some of the expansion files were generated manually vs. through codegen

@dprotaso dprotaso force-pushed the opt-in-dynamic-informers branch from 8a2f8d9 to b86bffc Compare May 16, 2023 15:53
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (300df43) 81.53% compared to head (b86bffc) 81.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2740   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files         163      163           
  Lines       10018    10018           
=======================================
  Hits         8168     8168           
  Misses       1606     1606           
  Partials      244      244           
Impacted Files Coverage Δ
apis/duck/v1/source_types.go 48.64% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso dprotaso changed the title Injection: Generation of informers backed by a dynamic client is opt-in [wip] Injection: Generation of informers backed by a dynamic client is opt-in May 16, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@dprotaso
Copy link
Member Author

Going to close this PR in favour of just removing this functionality

@dprotaso dprotaso closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop dynamic wrapped client generation
2 participants