-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Injection: Generation of informers backed by a dynamic client is opt-in #2740
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to delete "*_expansion.go" files like: https://github.com/knative/pkg/pull/2740/files#diff-e92a583ae998ed8bf58b1d9fc86498e11542cc490b73567452b26247284a0548
/hold |
Seems like some of the expansion files were generated manually vs. through codegen |
8a2f8d9
to
b86bffc
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2740 +/- ##
=======================================
Coverage 81.53% 81.53%
=======================================
Files 163 163
Lines 10018 10018
=======================================
Hits 8168 8168
Misses 1606 1606
Partials 244 244
☔ View full report in Codecov by Sentry. |
Going to close this PR in favour of just removing this functionality |
Fixes: #2739
A new flag now exists
-include-dynamic-informers
to produce the prior dynamic based informers