Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop use of pkg/test.KubeClient #655

Merged
merged 1 commit into from
Jun 10, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
drop use of pkg/test.KubeClient
  • Loading branch information
dprotaso committed Jun 9, 2021
commit 6f53bfa081d56bc5fae8ce9322e0fcdb550ec043
6 changes: 3 additions & 3 deletions test/clients.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,18 @@ package test

import (
"k8s.io/client-go/dynamic"
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/rest"
"k8s.io/client-go/tools/clientcmd"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"knative.dev/operator/pkg/client/clientset/versioned"
operatorv1alpha1 "knative.dev/operator/pkg/client/clientset/versioned/typed/operator/v1alpha1"
"knative.dev/pkg/test"
)

// Clients holds instances of interfaces for making requests to Knative Serving.
type Clients struct {
KubeClient *test.KubeClient
KubeClient kubernetes.Interface
Dynamic dynamic.Interface
Operator operatorv1alpha1.OperatorV1alpha1Interface
Config *rest.Config
Expand All @@ -50,7 +50,7 @@ func NewClients(configPath string, clusterName string) (*Clients, error) {
cfg.QPS = 100
cfg.Burst = 200

clients.KubeClient, err = test.NewKubeClient(configPath, clusterName)
clients.KubeClient, err = kubernetes.NewForConfig(cfg)
if err != nil {
return nil, err
}
Expand Down