Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: previous condition includes return statement, pop else statement #305

Merged
merged 1 commit into from
Oct 15, 2020
Merged

lint: previous condition includes return statement, pop else statement #305

merged 1 commit into from
Oct 15, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented Oct 14, 2020

Proposed Changes

  • The else statement isn't needed, the previous if statement includes a non-optional return

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 14, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2020
houshengbo
houshengbo reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thx for the contribution!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@knative-prow-robot knative-prow-robot merged commit ba86ac1 into knative:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houshengbo houshengbo houshengbo left review comments

@Cynocracy Cynocracy Awaiting requested review from Cynocracy

@trshafer trshafer Awaiting requested review from trshafer

Assignees

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lberk @knative-prow-robot @houshengbo