-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0.17 manifests into the operator #251
Add 0.17 manifests into the operator #251
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is there a script that picks these up and redoes the naming, or is that by hand? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The question about the script was for the kodata files, the test
file change clearly needs some human TLC.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's worth setting up a script to sync the releases files into these directories, and then have automation do the copy.
Right now, I'm looking that the files exist, but I'm not (for example) checking that they have exactly the same bytes as the ones released by the upstreams.
/test pull-knative-operator-upgrade-tests |
@evankanderson So far, this is done manually. |
7facc1f
to
c9baa16
Compare
/test pull-knative-operator-upgrade-tests |
/retest |
/test pull-knative-operator-upgrade-tests |
95f0222
to
e49f35b
Compare
e49f35b
to
3e38bbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I can take a shot at writing a script to generate these.
I noticed that you've added a numeric prefix to the manifests; any rules you've got about how to number the files?
All resources: For other resources in the middle: |
/test pull-knative-operator-integration-tests |
/test pull-knative-operator-upgrade-tests |
20ae117
to
f70011c
Compare
/lgtm |
Fixes: #253
Proposed Changes