Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.17 manifests into the operator #251

Merged
merged 4 commits into from
Aug 26, 2020

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Aug 20, 2020

Fixes: #253

Proposed Changes

  • This PR added the 0.17 manifests into the operator.
  • The Upgrade Prow changed the previous version of Knative into 0.16.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2020
@evankanderson
Copy link
Member

Is there a script that picks these up and redoes the naming, or is that by hand?

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The question about the script was for the kodata files, the test file change clearly needs some human TLC.)

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth setting up a script to sync the releases files into these directories, and then have automation do the copy.

Right now, I'm looking that the files exist, but I'm not (for example) checking that they have exactly the same bytes as the ones released by the upstreams.

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-upgrade-tests

@houshengbo
Copy link
Contributor Author

@evankanderson So far, this is done manually.

@houshengbo houshengbo changed the title Change 0.17 prow Add 0.17 manifests into the operator Aug 20, 2020
@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-upgrade-tests

@houshengbo
Copy link
Contributor Author

/retest

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-upgrade-tests

@houshengbo houshengbo closed this Aug 20, 2020
@houshengbo houshengbo reopened this Aug 20, 2020
@houshengbo houshengbo force-pushed the change-0.17-prow branch 2 times, most recently from 95f0222 to e49f35b Compare August 20, 2020 20:49
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I can take a shot at writing a script to generate these.

I noticed that you've added a numeric prefix to the manifests; any rules you've got about how to number the files?

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 24, 2020
@houshengbo
Copy link
Contributor Author

houshengbo commented Aug 25, 2020

All resources:
CRDs first, post jobs last.

For other resources in the middle:
Key component first(core files), other components second.

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-integration-tests

@houshengbo
Copy link
Contributor Author

/test pull-knative-operator-upgrade-tests

@Cynocracy
Copy link

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@knative-prow-robot knative-prow-robot merged commit fc1e605 into knative:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestInitialScalePostUpgrade failed as postupgrade test, after upgrading to 0.17 serving
5 participants