Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case studies index page and link from homepage #5869

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Case studies index page and link from homepage #5869

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6b40d3
Link to case studies
aliok Feb 15, 2024
f1c3913
Add a case studies page to link from homepage
aliok Feb 15, 2024
b14dc86
change the styling, and make the whole table row clickable
Leo6Leo Mar 1, 2024
cbfafa2
Merge branch '2024-02-15-case-studies-index-page' into add-styling-to…
aliok Mar 8, 2024
18957e3
Merge pull request #1 from Leo6Leo/add-styling-to-ali-branch
aliok Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ nav:
- Available Broker types: eventing/brokers/broker-types/README.md
# add default IMC broker page, page explaining broker types
- Channel based Broker: eventing/brokers/broker-types/channel-based-broker/README.md
- Apache Kafka:
- Apache Kafka:
- About Apache Kafka Broker: eventing/brokers/broker-types/kafka-broker/README.md
- Configuring Kafka features: eventing/brokers/broker-types/kafka-broker/configuring-kafka-features.md
- Creating a Broker: eventing/brokers/create-broker.md
Expand Down Expand Up @@ -309,6 +309,7 @@ nav:
- About:
- Testimonials: about/testimonials.md
- Case studies:
- List of Case Studies: about/case-studies/README.md
- deepc: about/case-studies/deepc.md
- Outfit7: about/case-studies/outfit7.md
- Puppet: about/case-studies/puppet.md
Expand Down
1 change: 0 additions & 1 deletion config/redirects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,5 @@ plugins:
serving/spec/knative-api-specification-1.0.md: https://github.com/knative/specs/blob/main/specs/serving/knative-api-specification-1.0.md
serving/using-an-ssl-cert/index.md: serving/encryption/using-certificates-in-networking-layer.md
serving/using-subroutes.md: serving/traffic-management.md
about/case-studies/README.md: about/case-studies/deepc.md
eventing/brokers/create-mtbroker.md: eventing/brokers/create-broker.md
eventing/brokers/broker-admin-config-options.md: eventing/configuration/broker-configuration.md
28 changes: 28 additions & 0 deletions docs/about/case-studies/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
hide:
- toc
---

# Knative Case Studies

<table>
<tr>
<td><a href="./deepc/"><img src="../../images/case-studies/deepc.png" alt="" draggable="false" style="max-width:300px;" /></a></td>
<td>AI Startup deepc Connects Researchers to Radiologists with Knative Eventing</td>
</tr>
<tr>
<td><a href="./outfit7/"><img src="../../images/case-studies/outfit7.png" alt="" draggable="false" style="max-width:300px;" /></a></td>
<td>Game maker Outfit7 automates high performance ad bidding with Knative Serving</td></tr>
<tr>
<td><a href="./pnc/"><img src="../../images/case-studies/pnc_bank.png" alt="" draggable="false" style="max-width:300px;" /></a></td>
<td>PNC Bank automated software supply chain compliance</td>
</tr>
<tr>
<td><a href="./puppet/"><img src="../../images/case-studies/puppet.png" alt="" draggable="false" style="max-width:300px;" /></a></td>
<td>Relay by Puppet Brings Workflows to Everything using Knative</td>
</tr>
<tr>
<td><a href="./sva/"><img src="../../images/case-studies/sva.png" alt="" draggable="false" style="max-width:300px;" /></a></td>
<td>SVA uses Knative to kickstart cloud native adoption and patterns</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would provide a better user experience if we make the whole table row clickable. Right now users have to click on the image in order to be redirected. Also the text can be centered to provide a better visual experience!

I made these changes in this PR. aliok#1

This is how it looks. @aliok Lmk if you think this is a reasonable change!
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Leo6Leo

I merged your PR against my fork.

One final look and then we can merge this one?

</tr>
</table>
2 changes: 1 addition & 1 deletion hack/docker/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ IMAGE=${3:-ghcr.io/knative/knative-docs:latest}

set -x

docker pull ${IMAGE}
docker pull ${IMAGE} --platform linux/amd64
docker run --rm -p "${PORT}:8000" -v "${SCRIPT_DIR}/../../:/site" ${IMAGE} serve --dirtyreload --dev-addr=0.0.0.0:8000

4 changes: 3 additions & 1 deletion overrides/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ <h2>Cloud agnostic</h2>

<section class="case-studies-container">
<div class="md-grid md-typeset">
<h1>Case Studies</h1>
<h1>
<a href="{{ 'about/case-studies/' | url }}">Case Studies</a>
</h1>
<div class="cases-table">
<div class="col">
<a href="{{ 'about/case-studies/deepc/' | url }}">
Expand Down
Loading