Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create autoscale-go image #5554

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 9, 2023

This created an autoscale-go image to replace the one hosted on gcr.io/knative-samples (which was removed)

@knative-prow knative-prow bot requested review from psschwei and snneji May 9, 2023 15:52
@knative-prow
Copy link

knative-prow bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 15f8dac
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/645a6c384281b500085be9a3
😎 Deploy Preview https://deploy-preview-5554--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2023
@krsna-m
Copy link
Contributor

krsna-m commented May 9, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@knative-prow knative-prow bot merged commit 098a9da into knative:main May 9, 2023
@dprotaso dprotaso deleted the autoscale-go-image branch May 9, 2023 16:03
@dprotaso
Copy link
Member Author

dprotaso commented Jun 5, 2023

/cherry-pick release-1.10

@knative-prow-robot
Copy link
Contributor

@dprotaso: #5554 failed to apply on top of branch "release-1.10":

Applying: create autoscale-go image
Using index info to reconstruct a base tree...
M	.github/workflows/knative-mkdocs-dockerimage.yaml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/knative-docs-image.yaml
CONFLICT (content): Merge conflict in .github/workflows/knative-docs-image.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 create autoscale-go image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants