Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated APIs for v0.14.0 release #2391

Merged
merged 9 commits into from
Apr 20, 2020
Merged

Updated APIs for v0.14.0 release #2391

merged 9 commits into from
Apr 20, 2020

Conversation

ellenevans
Copy link
Contributor

Generated API reference docs for v0.14.0 release

Fixes #issue-number or description of the problem the PR solves

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 14, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 14, 2020
@ellenevans
Copy link
Contributor Author

/assign carieshmarie

@ellenevans @mattmoor
Update docs/reference/eventing/eventing-contrib.md
1567397 
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
@ellenevans
Copy link
Contributor Author

There are two sets of links that are problematic in the API docs as generated - two in serving.md and one in eventing-contrib.md. I can fix the serving.md (https://git.k8s.io/community/contributors/devel/api-conventions.md) ones - they need to be https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md - but the eventing-contrib one is less clear. This is the wrong link: https://knative.dev/eventing-contrib/gitlab. I believe Timur is the author. I'm not sure what he wants there.

@ellenevans
Copy link
Contributor Author

The link check is now succeeding. Please review?

@ellenevans
Copy link
Contributor Author

Matt, the content of these docs is what the script generated, but given your edits, it looks like it generated a lot of incorrect content. Do you have any insight into why that might be the case, and how we can avoid having you do all that updating in the future?

@ellenevans @mattmoor
Update docs/reference/eventing/eventing-contrib.md
afdfb2e 
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
@carieshmarie carieshmarie added lgtm Indicates that a PR is ready to be merged. approved labels Apr 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ellenevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit cc6d24a into knative:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@samodell samodell Awaiting requested review from samodell

Assignees

@carieshmarie carieshmarie

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ellenevans @knative-prow-robot @mattmoor @googlebot @carieshmarie