Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron job source example: outdated image #2145

Closed
matejvasek opened this issue Jan 30, 2020 · 3 comments · Fixed by #2149
Closed

Cron job source example: outdated image #2145

matejvasek opened this issue Jan 30, 2020 · 3 comments · Fixed by #2149
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/high
Milestone
Backlog

Comments

@matejvasek
Copy link
Contributor

Expected Behavior

Log of the pod running the event-display service should contain information about received events (begins with "☁️ cloudevents.Event" as described in the example).

Actual Behavior

Log contains errors:
{"level":"error","ts":1580396460.0210204,"logger":"fallback","caller":"http/transport.go:408","msg":"failed to decode message","error":"unknown encoding","stacktrace":"github.com/knative/eventing-sources/vendor/github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http.(*Transport).ServeHTTP /go/src/github.com/knative/eventing-sources/vendor/github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http/transport.go:408 net/http.(*ServeMux).ServeHTTP /usr/local/go/src/net/http/server.go:2375 net/http.serverHandler.ServeHTTP /usr/local/go/src/net/http/server.go:2774 net/http.(*conn).serve /usr/local/go/src/net/http/server.go:1878"}

Steps to Reproduce the Problem

Follow Cron Job Source example from documentation.

Additional Info

The service yaml references older registry: gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display.
I believe it should reference newer registry: gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display (maybe with fixed revision).

Install information:

  • Knative Eventing Version: 0.12.0
@matejvasek matejvasek added the kind/bug Categorizes issue or PR as related to a bug. label Jan 30, 2020
@matejvasek
Copy link
Contributor Author

The gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display image is also used in some other places:

docs/eventing/getting-started.md docs/eventing/getting-started.md docs/eventing/samples/container-source/service.yaml docs/eventing/samples/container-source/README.md docs/eventing/samples/gcp-pubsub-source/event-display.yaml docs/eventing/samples/cronjob-source/service.yaml docs/eventing/samples/cronjob-source/README.md docs/eventing/samples/iot-core/trigger.yaml docs/eventing/samples/helloworld/helloworld-go/README.md docs/eventing/samples/parallel/mutual-exclusivity/event-display.yaml docs/eventing/samples/parallel/mutual-exclusivity/README.md docs/eventing/samples/parallel/multiple-branches/event-display.yaml docs/eventing/samples/parallel/multiple-branches/README.md

maybe it could caused problems there too.

matejvasek added a commit to matejvasek/docs that referenced this issue Jan 30, 2020
@matejvasek
Updated image reference for cron job source example.
9cb30b2 
gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display -> gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display

knative#2145
@samodell
Copy link
Contributor

Related to #2147 -- @vaikas should we update the eventdisplay URL to the one used in PR #2148 in these other locations in the docs?

@matejvasek matejvasek mentioned this issue Jan 30, 2020
Merged
@vaikas
Copy link
Contributor

vaikas commented Jan 31, 2020

Yes we should. That was my question in the docs meeting about using a variable and then when we push a new version, all these should change :)

@samodell samodell added this to the Backlog milestone Feb 12, 2020
knative-prow-robot pushed a commit that referenced this issue Feb 14, 2020
@matejvasek
Updated image reference for cron job source example. (#2149)
cb5d216 
gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display -> gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display

#2145
@erekgit erekgit mentioned this issue Jun 2, 2020
Closed
erekgit added a commit to erekgit/docs that referenced this issue Jun 2, 2020
@erekgit
event_display image seems wrong. produces "unknown encoding" error.
899ee26 
Using "gcr.io/knative-releases/github.com/knative/eventing-contrib/cmd/event_display: produces "unknown encoding error" in this Example.  

Switching to image @ gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display resolves these issues for me.

See: knative#2145
@erekgit erekgit mentioned this issue Jun 2, 2020
Merged
knative-prow-robot pushed a commit that referenced this issue Jun 2, 2020
@erekgit
event_display image seems wrong. produces "unknown encoding" error. (#…
080d4c3 
…2532)

Using "gcr.io/knative-releases/github.com/knative/eventing-contrib/cmd/event_display: produces "unknown encoding error" in this Example.  

Switching to image @ gcr.io/knative-releases/knative.dev/eventing-contrib/cmd/event_display resolves these issues for me.

See: #2145
hhellbusch added a commit to hhellbusch/knative_foundations_labs that referenced this issue Aug 4, 2020
@hhellbusch
updated image reference for event_display
0b4aa66 
based on knative/docs#2145
@hhellbusch hhellbusch mentioned this issue Aug 4, 2020
Open
JishnuM added a commit to JishnuM/kfserving that referenced this issue May 17, 2021
@JishnuM
Update path in README to be consistent with code
2dd6045 
The outdated image does not work, see knative/docs#2145 for more context.
@JishnuM JishnuM mentioned this issue May 17, 2021
Merged
google-oss-robot pushed a commit to kserve/kserve that referenced this issue May 17, 2021
@JishnuM
Update path in README to be consistent with code (#1616)
a0d0d18 
The outdated image does not work, see knative/docs#2145 for more context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/high
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Updated image reference for cron job source example. matejvasek/docs
3 participants
@matejvasek @vaikas @samodell