Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trigger): Backport trigger filter fixes #749

Merged
merged 5 commits into from
Mar 24, 2020
Merged

fix(trigger): Backport trigger filter fixes #749

merged 5 commits into from
Mar 24, 2020

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Mar 19, 2020 •
edited
Loading

Description

Backport trigger filter fixes to 0.13.x release.

Changes

Note: I've updated changelog to point to next 0.13.1 release, but I'm not quiet sure about PR ref. Should the URL point to original PR or this one?

dsimansk added 3 commits March 19, 2020 20:11
@dsimansk
fix(trigger): Make --filter flag truly optional (knative#745)
cbfa1e6 
* fix(trigger): Make --filter flag truly optional

* fix(trigger): Update trigger docs

* chore: Update changelog
@dsimansk
fix(trigger): Fix filter delete for trigger update (knative#746)
d5427b5
@dsimansk
chore: Update changelog
72496d4
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 19, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2020
rhuss
rhuss reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine to refer to the original PRs if nothing substantial has to be adapted.

The question now is more, when to merge this PR because as soon as it is merged it would trigger automatically a dot-release (on tuesday), so I wonder whether we want to add more for 0.13.1

So should we merge now, or "park" it until we have all issues fixed for 0.13.1 ? (do we have any ?)

Also, when this is merged we need to update the Changelog.adoc on master, too.

@dsimansk
Copy link
Contributor Author

I think "Windows plugin issue" is a good candidate for a backport too, #738.

@MIBc @dsimansk
Fix plugin execution for Windows (knative#738)
0b60531 
Fixes knative#737

* Use exec.Command instend of syscall.Exec for windows.
* Fix a bug in plugin handler test when running it on windows.
* Fix typo.
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Mar 20, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2020
@dsimansk
Copy link
Contributor Author

Added cherry-pick 5e73d8d

@MIBc could you please add comment @googlebot I consent. to make CLA bot happy, see the above.

@MIBc
Copy link
Contributor

MIBc commented Mar 23, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Mar 23, 2020
@dsimansk
Copy link
Contributor Author

Added cherry-pick a0a762b

rhuss
rhuss approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@knative-prow-robot knative-prow-robot merged commit 6e3fac0 into knative:release-0.13 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsimansk @googlebot @MIBc @knative-prow-robot @rhuss