Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #338 by adding documentation for the Kn config #411

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Fixes issue #338 by adding documentation for the Kn config #411

merged 2 commits into from
Oct 1, 2019

Conversation

maximilien
Copy link
Contributor

@maximilien maximilien commented Sep 20, 2019 •
edited
Loading

Fixes #338

Proposed Changes

  • documentation for Kn config
  • details on Kn plugins configuration parameters

Release Note:

  • 🎁 docs for Kn config

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 20, 2019
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2019
rhuss
rhuss requested changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! see my comments inline please.

@maximilien maximilien mentioned this pull request Sep 23, 2019
Closed
@maximilien maximilien mentioned this pull request Sep 27, 2019
Closed
navidshaikh
navidshaikh requested changes Sep 28, 2019
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos and few suggestions to update contents

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2019
navidshaikh
navidshaikh approved these changes Oct 1, 2019
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
/assign @rhuss

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
rhuss
rhuss approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss
Copy link
Contributor

rhuss commented Oct 1, 2019

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@knative-prow-robot knative-prow-robot merged commit dba0d11 into knative:master Oct 1, 2019
@maximilien maximilien deleted the issue338 branch December 20, 2019 22:30
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@srinivashegde86 @knative-prow-robot
Add a presubmit job to run perf tests (knative#411)
35c51c1 
* Add a presubmit job to run perf tests

* Dont always run PR perf job

* Skip 0.3 as it has been released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@navidshaikh navidshaikh navidshaikh approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@rhuss rhuss

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs about the ~/.kn/config config file
5 participants
@maximilien @knative-prow-robot @rhuss @navidshaikh @googlebot