Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Azure auth provider #1616

Merged

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Mar 4, 2022

Description

While looking for a fix to "missing Azure auth provider I've found mention of enabling all builtin providers, #35. That seems very reasonable within this context.

Changes

  • 🐛 Fix missing Azure auth provider
  • Regroup imports in the changed file

Reference

Fixes #1615 #35

PTAL
/cc @vyasgun @maximilien

Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 0 warnings.

In response to this:

Description

Changes

  • 🐛 Fix missing Azure auth provider
  • Regroup imports in the changed file

Reference

Fixes #1615

PTAL
/cc @vyasgun @maximilien

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1616 (5c6ae2a) into main (621ddbb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1616   +/-   ##
=======================================
  Coverage   79.96%   79.96%           
=======================================
  Files         171      171           
  Lines        9089     9089           
=======================================
  Hits         7268     7268           
  Misses       1109     1109           
  Partials      712      712           
Impacted Files Coverage Δ
pkg/kn/root/root.go 88.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 621ddbb...5c6ae2a. Read the comment docs.

Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@navidshaikh navidshaikh linked an issue Mar 4, 2022 that may be closed by this pull request
@navidshaikh
Copy link
Collaborator

linked #35

@vyasgun
Copy link
Contributor

vyasgun commented Mar 4, 2022

/lgtm

@dsimansk
Copy link
Contributor Author

dsimansk commented Mar 4, 2022

/retest

@knative-prow-robot knative-prow-robot merged commit d12d4cd into knative:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: no Auth Provider found for name "azure" allow all builtin auth providers
4 participants