-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing Azure auth provider #1616
Fix missing Azure auth provider #1616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsimansk: 0 warnings.
In response to this:
Description
Changes
- 🐛 Fix missing Azure auth provider
- Regroup imports in the changed file
Reference
Fixes #1615
PTAL
/cc @vyasgun @maximilien
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
=======================================
Coverage 79.96% 79.96%
=======================================
Files 171 171
Lines 9089 9089
=======================================
Hits 7268 7268
Misses 1109 1109
Partials 712 712
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
linked #35 |
/lgtm |
/retest |
Description
While looking for a fix to "missing Azure auth provider I've found mention of enabling all builtin providers, #35. That seems very reasonable within this context.
Changes
Reference
Fixes #1615 #35
PTAL
/cc @vyasgun @maximilien