Fix domain describe reference

[dsimansk]

Description

➜  client git:(pr/fix-domain-describe) kn domain describe hello.nip.io        
Name:       hello.nip.io
Namespace:  default
Age:        2h

URL:           http://hello.nip.io

Reference:     
  APIVersion:  serving.knative.dev/v1
  Kind:        Route
  Name:        hello

Conditions:  
  OK TYPE                      AGE REASON
  !! Ready                      2h DomainAlreadyClaimed
  ?? CertificateProvisioned     2h 
  !! DomainClaimed              2h DomainAlreadyClaimed
  ?? IngressReady               2h IngressNotConfigured
  ?? ReferenceResolved          2h 

/cc @rhuss
Is too verbove, I can't make up my mind if APIVersion should be part of the output?

Changes

• Fix domain describe reference

Reference

Fixes #1450

[knative-prow-robot]

@dsimansk: 0 warnings.

In response to this:

Description

➜  client git:(pr/fix-domain-describe) kn domain describe hello.nip.io        
Name:       hello.nip.io
Namespace:  default
Age:        2h

URL:           http://hello.nip.io
Reference:     
 APIVersion:  serving.knative.dev/v1
 Kind:        Route
 Name:        hello

Conditions:  
 OK TYPE                      AGE REASON
 !! Ready                      2h DomainAlreadyClaimed
 ?? CertificateProvisioned     2h 
 !! DomainClaimed              2h DomainAlreadyClaimed
 ?? IngressReady               2h IngressNotConfigured
 ?? ReferenceResolved          2h 

Changes

• Fix domain describe reference

Reference

Fixes #1450

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1477 (b3d718d) into main (b1e4132) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
+ Coverage   79.10%   79.14%   +0.03%     
==========================================
  Files         162      162              
  Lines        8443     8449       +6     
==========================================
+ Hits         6679     6687       +8     
+ Misses       1080     1079       -1     
+ Partials      684      683       -1     

Impacted Files	Coverage Δ
pkg/kn/commands/domain/describe.go	80.76% <100.00%> (+6.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e4132...b3d718d. Read the comment docs.

[dsimansk]

/retest

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/domain/describe.go	85.4%	89.4%	4.0

[dsimansk]

net/http: TLS handshake timeout

/retest

[dsimansk]

PTAL
/cc @knative/client-writers

[itsmurugappan]

Having the API version seems ok for me.

[itsmurugappan]

looks good to me

[dsimansk]

@rhuss or @maximilien or @navidshaikh PTAL:)

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

Per Navid's comment moving on with current impl.
/unhold