Update Eventing Sources API to v1 #1299

dsimansk · 2021-04-30T09:50:01Z

Description

Follow-up on recent v1alpha1 removal from Eventing main.
knative/eventing#5318

Changes

Update to APIServerSource, ContainerSource, PingSource & SinkBinding API to sources/v1

/cc @knative/client-reviewers

knative-prow-robot

@dsimansk: 0 warnings.

In response to this:

Description

Follow-up on recent v1alpha1 removal from Eventing main.
knative/eventing#5318

Changes

Update to APIServerSource, ContainerSource, PingSource & SinkBinding API to sources/v1

/cc @knative/client-reviewers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dsimansk · 2021-04-30T10:43:50Z

There's one open question though. PingSource was promoted to v1 API just now, that's why integration tests are failing currently. For that reason we can't use PingSource v1 on 0.22 as well, breaking the backward compatibility, therefore we need to keep PingSource at v1beta2 for now. (applying the common client API policy keeping the lowest version until available)

@rhuss @maximilien any objections to the above? I'm mainly asking due to implications for 1.0 release etc.

rhuss · 2021-04-30T10:58:44Z

Yeah, let's stay with PingSource v1beta2.

If Eventing goes to Knative 1.0 with v1beta2, too, I don't see any problems to use this for a 1.0 client.

rhuss · 2021-04-30T10:59:15Z

@lionelvillard Are there any plans for Evention 1.0 to remove PingSource v1beta2, too ?

lionelvillard · 2021-04-30T12:04:01Z

@lionelvillard Are there any plans for Evention 1.0 to remove PingSource v1beta2, too ?

We have to keep v1beta2 for at least of couple of releases.

dsimansk · 2021-04-30T13:42:31Z

/retest

rhuss · 2021-04-30T15:10:39Z

pkg/kn/commands/source/ping/create_test.go


 	"knative.dev/client/pkg/util"
 )

 func TestSimpleCreatePingSource(t *testing.T) {
 	mysvc := &servingv1.Service{
-		TypeMeta:   v1.TypeMeta{Kind: "Service", APIVersion: "serving.knative.dev/v1"},
-		ObjectMeta: v1.ObjectMeta{Name: "mysvc", Namespace: "default"},
+		TypeMeta:   metav1.TypeMeta{Kind: "Service", APIVersion: "serving.knative.dev/v1beta2"},


Serving v1beta2 ?

rhuss

Looks good, however while cross checking it looks like that there has been a gotcha when reverting from v1 back to v1beta2 for the ping source (see comment inline). Not sure if other parts are affected, too.

rhuss · 2021-04-30T16:31:14Z

/retest

/lgtm
/approve

maximilien

/ok-to-test
/lgtm

rhuss · 2021-05-02T12:18:08Z

Looks like that the test indeed captured a valid issue:

source_list_test.go:85: assertion failed: 
        Actual output: NAME              TYPE         RESOURCE                          SINK   READY
        testpingsource0   PingSource   pingsources.sources.knative.dev          True
        
        Missing strings: ksvc:testsvc0

i.e. there is no output of the connected sink.

dsimansk · 2021-05-02T19:45:29Z

Looks like that the test indeed captured a valid issue:

source_list_test.go:85: assertion failed: 
        Actual output: NAME              TYPE         RESOURCE                          SINK   READY
        testpingsource0   PingSource   pingsources.sources.knative.dev          True
        
        Missing strings: ksvc:testsvc0

i.e. there is no output of the connected sink.

Well, this one was pretty hard to find actually. 😓
The error is caused by failed unstructured conversion due to knative/eventing@7c0b477.

Update: adding more details. The above change/fix was backported to Eventing patch release 0.22.1. Therefore the next client release will fully work with v1beta2 PingSource and Eventing 0.22.1 combination.
The only issue is with 0.22.0 and kn source list - general source, list that uses Unstructured to list all present sources, doesn't display sink reference (or further details with -o yaml, etc.), but kn source ping describe and everything else related to PingSource CRUD operations is OK.

knative-metrics-robot · 2021-05-02T19:46:14Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/types.go	55.1%	57.8%	2.7
pkg/sources/common.go	Do not exist	100.0%
pkg/sources/v1/apiserver_client.go	Do not exist	90.0%
pkg/sources/v1/apiserver_client_mock.go	Do not exist	77.3%
pkg/sources/v1/binding_client.go	Do not exist	84.7%
pkg/sources/v1/binding_client_mock.go	Do not exist	90.9%
pkg/sources/v1/client.go	Do not exist	100.0%
pkg/sources/v1/container_client.go	Do not exist	89.5%
pkg/sources/v1/container_client_mock.go	Do not exist	90.9%
pkg/sources/v1beta2/client.go	Do not exist	100.0%
pkg/sources/v1beta2/ping_client.go	Do not exist	90.0%
pkg/sources/v1beta2/ping_client_mock.go	Do not exist	77.3%

rhuss · 2021-05-03T10:11:41Z

The only issue with 0.22.0 ...

That's fine I would say, as we can always say that's an issue with the backend and the fix is, to update the eventing backend to 0.22.1

rhuss · 2021-05-03T10:11:52Z

/lgtm
/approve

knative-prow-robot · 2021-05-03T10:12:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsimansk added 2 commits April 30, 2021 11:45

Update Eventing Sources API to v1

61abdab

Update vendor dir

9f1ca07

google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 30, 2021

knative-prow-robot reviewed Apr 30, 2021

View reviewed changes

knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 30, 2021

Fix imports formatting

4fc39dc

Move PingSource client to v1beta2

966bbed

Fix sink resolve

7027c09

rhuss reviewed Apr 30, 2021

View reviewed changes

rhuss requested changes Apr 30, 2021

View reviewed changes

Fix serving version string

bfd3814

knative-prow-robot assigned rhuss Apr 30, 2021

knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2021

maximilien reviewed Apr 30, 2021

View reviewed changes

knative-prow-robot assigned maximilien Apr 30, 2021

knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 30, 2021

Use Eventing version 0.22.1 in e2e tests

fd387db

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021

knative-prow-robot merged commit e5b19e1 into knative:main May 3, 2021

dsimansk deleted the pr/sources-v1 branch May 3, 2021 11:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Eventing Sources API to v1 #1299

Update Eventing Sources API to v1 #1299

dsimansk commented Apr 30, 2021

knative-prow-robot left a comment

dsimansk commented Apr 30, 2021 •

edited

Loading

rhuss commented Apr 30, 2021

rhuss commented Apr 30, 2021

lionelvillard commented Apr 30, 2021

dsimansk commented Apr 30, 2021

rhuss Apr 30, 2021

dsimansk Apr 30, 2021

rhuss left a comment

rhuss commented Apr 30, 2021

maximilien left a comment

rhuss commented May 2, 2021 •

edited

Loading

dsimansk commented May 2, 2021 •

edited

Loading

knative-metrics-robot commented May 2, 2021

rhuss commented May 3, 2021

rhuss commented May 3, 2021

knative-prow-robot commented May 3, 2021

Update Eventing Sources API to v1 #1299

Update Eventing Sources API to v1 #1299

Conversation

dsimansk commented Apr 30, 2021

Description

Changes

knative-prow-robot left a comment

Choose a reason for hiding this comment

Description

Changes

dsimansk commented Apr 30, 2021 • edited Loading

rhuss commented Apr 30, 2021

rhuss commented Apr 30, 2021

lionelvillard commented Apr 30, 2021

dsimansk commented Apr 30, 2021

rhuss Apr 30, 2021

Choose a reason for hiding this comment

dsimansk Apr 30, 2021

Choose a reason for hiding this comment

rhuss left a comment

Choose a reason for hiding this comment

rhuss commented Apr 30, 2021

maximilien left a comment

Choose a reason for hiding this comment

rhuss commented May 2, 2021 • edited Loading

dsimansk commented May 2, 2021 • edited Loading

knative-metrics-robot commented May 2, 2021

rhuss commented May 3, 2021

rhuss commented May 3, 2021

knative-prow-robot commented May 3, 2021

dsimansk commented Apr 30, 2021 •

edited

Loading

rhuss commented May 2, 2021 •

edited

Loading

dsimansk commented May 2, 2021 •

edited

Loading