Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "completion" to help message (again) #477

Closed
rhuss opened this issue Nov 5, 2019 · 0 comments · Fixed by #478
Closed

Add "completion" to help message (again) #477

rhuss opened this issue Nov 5, 2019 · 0 comments · Fixed by #478
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals.

Comments

@rhuss
Copy link
Contributor

rhuss commented Nov 5, 2019

In what area(s)?

kn help

Describe the feature:

Re-add kn completion to top-level help message as this is missing currently. Not sure why we removed it, so let's first discucss/decide this here.
@rhuss rhuss added the kind/feature New feature or request label Nov 5, 2019
@knative-prow-robot knative-prow-robot added good first issue Denotes an issue ready for a new contributor. kind/proposal Issues or PRs related to proposals. labels Nov 5, 2019
@rhuss rhuss mentioned this issue Nov 5, 2019
Merged
navidshaikh added a commit to navidshaikh/client that referenced this issue Nov 5, 2019
@navidshaikh
Add completion to help message
6ff3413 
 Fixes knative#477
@navidshaikh navidshaikh mentioned this issue Nov 5, 2019
Merged
navidshaikh added a commit to navidshaikh/client that referenced this issue Nov 12, 2019
@navidshaikh
Add completion to help message
c86555b 
 Fixes knative#477
navidshaikh added a commit to navidshaikh/client that referenced this issue Nov 12, 2019
@navidshaikh
Add completion to help message
9e8f48e 
 Fixes knative#477
knative-prow-robot pushed a commit that referenced this issue Nov 12, 2019
@navidshaikh @knative-prow-robot
Add completion to help message (#478)
c4a9197 
Fixes #477
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@chaodaiG @knative-prow-robot
Make --run-test skip unnecessary testing on presubmit (knative#477)
6972ae2 
* Add --run-presubmit-tests flag to presubmit-tests.sh

presubmit-tests.sh is used by both presubmit and continuous jobs, they don't always execute the same set of tests. Add a flag to make it easier to separate. Also add logic to skip running tests for documentation only PRs if it's presubmit test

* remove the flag
dsimansk added a commit to dsimansk/client that referenced this issue Nov 6, 2024
@dsimansk
Fix script location (knative#477)
70eae6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add completion to help message navidshaikh/client
2 participants
@rhuss @knative-prow-robot