Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💝 Run Go tests for each module #223

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 2, 2024

Changes

  • 💝 Run Go tests for each module

/kind enhancement

Fixes #

@knative-prow knative-prow bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 2, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2024
cardil added a commit to cardil/knative-client that referenced this pull request Sep 2, 2024
@cardil cardil force-pushed the feature/unit-test-each-go-module branch from e63b4e6 to f3a11aa Compare September 2, 2024 19:20
@cardil cardil marked this pull request as ready for review September 2, 2024 19:25
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2024
@knative-prow knative-prow bot requested a review from mgencur September 2, 2024 19:25
@cardil
Copy link
Contributor Author

cardil commented Sep 2, 2024

/cc @dsimansk

@knative-prow knative-prow bot requested a review from dsimansk September 2, 2024 19:27
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cardil! Looks good to me.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
Copy link

knative-prow bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 197e13a into knative:main Sep 3, 2024
7 checks passed
@cardil cardil deleted the feature/unit-test-each-go-module branch September 3, 2024 09:36
knative-prow bot pushed a commit to knative/client that referenced this pull request Sep 3, 2024
* Move to the hack' script inflator

* Skip kn subpackage

* Move the lib/ to public pkg/ packages

* Introduce pkg submodule, remove the vendor dir

* Remove vendor references

* Use latest version of knative.dev/hack

* Publish dependent images properly

* Walkaround for knative-extensions/net-istio#1345

* Remove GOTOOLCHAIN in go.work

* Verify codegen use common funcs

* Import code from knative.dev/client-pkg

* Restore the default unit test runner

* Try knative/actions#223

* Restore the workflows

* Nit: simplify config package import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants