Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop use of knative.dev/pkg/test.KubeClient #664

Merged
merged 1 commit into from
Jun 10, 2021
Merged

drop use of knative.dev/pkg/test.KubeClient #664

merged 1 commit into from
Jun 10, 2021

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jun 9, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 9, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2021
@dprotaso dprotaso mentioned this pull request Jun 9, 2021
Merged
3 tasks
@codecov
Copy link

codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #664 (82aa026) into main (00a2c8a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   80.21%   80.21%           
=======================================
  Files          18       18           
  Lines        1107     1107           
=======================================
  Hits          888      888           
  Misses        135      135           
  Partials       84       84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542899c...82aa026. Read the comment docs.

nak3
nak3 approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@nak3 nak3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3df5559 into knative-extensions:main Jun 10, 2021
@dprotaso dprotaso deleted the drop-kubeclient branch June 10, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nak3 nak3 nak3 approved these changes

Assignees

@nak3 nak3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @knative-prow-robot @nak3