Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing common labels on kcert #1329

Merged
merged 1 commit into from
May 31, 2024

Conversation

ReToCode
Copy link
Member

Changes

  • Add missing common labels on kcert
  • Without these, the operator does not properly select these YAMLs

/assign @skonto

/cherry-pick release-1.14

Copy link

knative-prow bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from izabelacg and skonto May 31, 2024 07:10
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (995d045) to head (146ba18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files          26       26           
  Lines        1668     1668           
=======================================
  Hits         1372     1372           
  Misses        195      195           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented May 31, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@skonto
Copy link
Contributor

skonto commented May 31, 2024

Are there any other resources that need this or we are good?

@knative-prow knative-prow bot merged commit 1a06d7e into knative-extensions:main May 31, 2024
36 checks passed
@ReToCode
Copy link
Member Author

Are there any other resources that need this or we are good?

I think the rest is fine, I added this YAML and just missed the labels

@ReToCode
Copy link
Member Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #1330

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants