Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Event sending docs with --to option acting as a sink #369

Closed
wants to merge 1 commit into from

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Oct 2, 2024

Align the docs to #368 changes

Changes

  • 🎁 Event sending docs with --to option acting as a sink

/kind documentation

Follow up #368

Align the docs to #368 changes
Copy link

knative-prow bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and rhuss October 2, 2024 11:16
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.26%. Comparing base (3f209e4) to head (444b1dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   69.26%   69.26%           
=======================================
  Files          48       48           
  Lines        1246     1246           
=======================================
  Hits          863      863           
  Misses        313      313           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil cardil closed this Oct 2, 2024
@cardil cardil deleted the docs/event-sending branch October 2, 2024 11:22
@cardil
Copy link
Contributor Author

cardil commented Oct 2, 2024

This was invalid PR. The proper one is #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant