Rework the way eventing-rabbitmq does Rabbit codegen #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19f27f9 to
4a2beb6
Compare
Today we rerun codegen for the Rabbit clients to get injection, but because they use kubebuilder their layout is a bit strange. There's a hack to temporarily copy the api types into the right structure, and then undo it, which is a bit fragile (if codegen references that package, then it won't build!). We also try to contort so that we can use their existing client/informer/lister codegen, which isn't really necessary. With this change, we instead permanently copy the types into a suitable structure under `third_party/pkg/apis` and generate all of the clients we need under `third_party/pkg/client`. This is a slight superset of what Istio and Contour are already doing (we don't need to copy those types), and feels a bit simpler (and less fragile) than what we are currently doing. /kind cleanup
|
This seems like a fine way to handle out of tree codegen for oddly layed out apis. 👍 |
4a2beb6 to
f5bf069
Compare
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 75.54% 75.54%
=======================================
Files 44 44
Lines 2781 2781
=======================================
Hits 2101 2101
Misses 548 548
Partials 132 132
Continue to review full report at Codecov.
|
mattmoor
added a commit
to mattmoor/eventing-autoscaler-keda
that referenced
this pull request
Aug 17, 2021
Today we rerun codegen for the Rabbit clients to get injection, but because they use kubebuilder their layout is a bit strange. There's a hack to temporarily copy the api types into the right structure, and then undo it, which is a bit fragile (if codegen references that package, then it won't build!). We also try to contort so that we can use their existing client/informer/lister codegen, which isn't really necessary. With this change, we instead permanently copy the types into a suitable structure under third_party/pkg/apis and generate all of the clients we need under third_party/pkg/client. This is a slight superset of what Istio and Contour are already doing (we don't need to copy those types), and feels a bit simpler (and less fragile) than what we are currently doing. /kind cleanup Ref (same for rabbitmq): knative-extensions/eventing-rabbitmq#378
mattmoor
added a commit
to mattmoor/eventing-autoscaler-keda
that referenced
this pull request
Aug 17, 2021
Today we rerun codegen for the Rabbit clients to get injection, but because they use kubebuilder their layout is a bit strange. There's a hack to temporarily copy the api types into the right structure, and then undo it, which is a bit fragile (if codegen references that package, then it won't build!). We also try to contort so that we can use their existing client/informer/lister codegen, which isn't really necessary. With this change, we instead permanently copy the types into a suitable structure under third_party/pkg/apis and generate all of the clients we need under third_party/pkg/client. This is a slight superset of what Istio and Contour are already doing (we don't need to copy those types), and feels a bit simpler (and less fragile) than what we are currently doing. /kind cleanup Ref (same for rabbitmq): knative-extensions/eventing-rabbitmq#378
mattmoor
added a commit
to mattmoor/eventing-autoscaler-keda
that referenced
this pull request
Aug 17, 2021
Today we rerun codegen for the Rabbit clients to get injection, but because they use kubebuilder their layout is a bit strange. There's a hack to temporarily copy the api types into the right structure, and then undo it, which is a bit fragile (if codegen references that package, then it won't build!). We also try to contort so that we can use their existing client/informer/lister codegen, which isn't really necessary. With this change, we instead permanently copy the types into a suitable structure under third_party/pkg/apis and generate all of the clients we need under third_party/pkg/client. This is a slight superset of what Istio and Contour are already doing (we don't need to copy those types), and feels a bit simpler (and less fragile) than what we are currently doing. /kind cleanup Ref (same for rabbitmq): knative-extensions/eventing-rabbitmq#378
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
pushed a commit
to knative-extensions/eventing-autoscaler-keda
that referenced
this pull request
Aug 17, 2021
Today we rerun codegen for the Rabbit clients to get injection, but because they use kubebuilder their layout is a bit strange. There's a hack to temporarily copy the api types into the right structure, and then undo it, which is a bit fragile (if codegen references that package, then it won't build!). We also try to contort so that we can use their existing client/informer/lister codegen, which isn't really necessary. With this change, we instead permanently copy the types into a suitable structure under third_party/pkg/apis and generate all of the clients we need under third_party/pkg/client. This is a slight superset of what Istio and Contour are already doing (we don't need to copy those types), and feels a bit simpler (and less fragile) than what we are currently doing. /kind cleanup Ref (same for rabbitmq): knative-extensions/eventing-rabbitmq#378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we rerun codegen for the Rabbit clients to get injection, but because they use kubebuilder their layout is a bit strange. There's a hack to temporarily copy the api types into the right structure, and then undo it, which is a bit fragile (if codegen references that package, then it won't build!). We also try to contort so that we can use their existing client/informer/lister codegen, which isn't really necessary.
With this change, we instead permanently copy the types into a suitable structure under
third_party/pkg/apisand generate all of the clients we need underthird_party/pkg/client. This is a slight superset of what Istio and Contour are already doing (we don't need to copy those types), and feels a bit simpler (and less fragile) than what we are currently doing./kind cleanup
/assign @n3wscott
Release Note
Docs