Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align w/ Quarkus 3.15 and friends #4245

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Align w/ Quarkus 3.15 and friends #4245

merged 1 commit into from
Feb 4, 2025

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Feb 4, 2025

Try with 3.15.2 - since 3.15.3 has a netty bug

Fixes #

Proposed Changes

  • as per title

Release Note

Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2025
@matzew matzew mentioned this pull request Feb 4, 2025
Closed
matzew
matzew commented Feb 4, 2025
View reviewed changes
data-plane/receiver/pom.xml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (8bf8b30) to head (741fc24).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4245   +/-   ##
=======================================
  Coverage   45.32%   45.32%           
=======================================
  Files         290      290           
  Lines       19869    19869           
=======================================
  Hits         9005     9005           
  Misses      10151    10151           
  Partials      713      713

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew commented Feb 4, 2025
View reviewed changes
data-plane/core/pom.xml
@@ -181,7 +181,7 @@

<dependency>
<groupId>io.micrometer</groupId>
<artifactId>micrometer-registry-prometheus</artifactId>
<artifactId>micrometer-registry-prometheus-simpleclient</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the simpleclient, since that is backwards compatible to the old APIs.

While vertx-micrometer 4.5.10 is still on the 1.12 APIs, we do inherit the 1.13 APIs via the Quarkus BOM...
And hence we really need the simpleclient, we are using that - to avoid nasty breakages

@matzew matzew force-pushed the quarkus_3.15.2_updates branch from 060cda9 to 4dc46d9 Compare February 4, 2025 07:31
@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/test reconciler-tests-namespaced-broker

the usual source of failures...

@matzew matzew mentioned this pull request Feb 4, 2025
Closed
@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/retest

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/retest

@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/test reconciler-tests

2 similar comments
@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/test reconciler-tests

@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/test reconciler-tests

pierDipi
pierDipi approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2025
@matzew
Align w/ Quarkus 3.15 and friends
741fc24 
Try with 3.15.2

We change the mircometer-prometheus client dependency, because the simpleclient is backwards compatible to the old APIs.
While vertx-micrometer 4.5.10 is still on the 1.12 APIs, we do inherit the 1.13 micrometer APIs via the Quarkus BOM...
And hence we really need the simpleclient, we are using that, to avoid clash

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the quarkus_3.15.2_updates branch from 4dc46d9 to 741fc24 Compare February 4, 2025 14:51
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2025
@pierDipi
Copy link
Member

pierDipi commented Feb 4, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/retest

@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/test upgrade-tests

@knative-prow knative-prow bot merged commit 3232420 into knative-extensions:main Feb 4, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @pierDipi @knative-prow-robot