Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use and test KafkaSource v1 API #4138

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Use and test KafkaSource v1 API #4138

merged 1 commit into from
Dec 2, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 15, 2024 •
edited
Loading

Replace usages of v1beta1 KafkaSource to v1 KafkaSource

Part of #3953

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 15, 2024
@knative-prow knative-prow bot requested review from Cali0707 and creydr October 15, 2024 13:20
@pierDipi pierDipi force-pushed the migrate-to-sources-v1-apis branch from 09908e5 to 0340e6d Compare October 16, 2024 05:15
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.51%. Comparing base (6235e66) to head (243538b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rnalskafkaeventing/v1alpha1/consumer_validation.go 0.00% 2 Missing ⚠️
control-plane/pkg/autoscaler/keda/keda.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4138      +/-   ##
==========================================
- Coverage   45.53%   45.51%   -0.02%     
==========================================
  Files         270      270              
  Lines       19925    19925              
==========================================
- Hits         9072     9069       -3     
- Misses      10127    10129       +2     
- Partials      726      727       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/retest-required

@pierDipi
Copy link
Member Author

This can be merged only after 1.16 is out

@pierDipi
Copy link
Member Author

/retest

@pierDipi
Use and test KafkaSource v1 API
243538b 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the migrate-to-sources-v1-apis branch from 0340e6d to 243538b Compare November 25, 2024 13:06
@pierDipi pierDipi changed the title [WIP] Use and test KafkaSource v1 API Use and test KafkaSource v1 API Dec 2, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
matzew
matzew reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

pierDipi commented Dec 2, 2024

/retest

@knative-prow knative-prow bot merged commit 177b61a into knative-extensions:main Dec 2, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@creydr creydr Awaiting requested review from creydr

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @matzew