Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go version in go mod is correct now #3950

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Cali0707
Copy link
Member

Fixes issues with go mod tidy resulting from an incorrect go mod file. See golang/go#62278 (comment) for more info

Proposed Changes

  • Move from go 1.22 to explicit go 1.22.3

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

/cc @creydr @pierDipi

@knative-prow knative-prow bot requested review from lionelvillard and matzew June 25, 2024 14:40
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024
@knative-prow knative-prow bot requested review from creydr and pierDipi June 25, 2024 14:40
Copy link

knative-prow bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.24%. Comparing base (b5bb25a) to head (208353e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3950   +/-   ##
=======================================
  Coverage   48.24%   48.24%           
=======================================
  Files         246      246           
  Lines       14500    14500           
=======================================
  Hits         6995     6995           
  Misses       6799     6799           
  Partials      706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Contributor

creydr commented Jun 25, 2024

Hey @Cali0707,
thanks for checking on this. Do you know, if this value will then be updated over time, or do we have to bump it manually?

@Cali0707
Copy link
Member Author

Do you know, if this value will then be updated over time, or do we have to bump it manually?

Not sure, but I imagine we will have to bump this ourselves sadly...

@creydr
Copy link
Contributor

creydr commented Jun 26, 2024

Not sure, but I imagine we will have to bump this ourselves sadly...

Ok. IIRC we had to do this in the past anyhow (for minor versions)

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@creydr
Copy link
Contributor

creydr commented Jun 26, 2024

/test upgrade-tests

@knative-prow knative-prow bot merged commit 63d6859 into knative-extensions:main Jun 26, 2024
33 checks passed
pierDipi added a commit that referenced this pull request Jun 27, 2024
knative-prow bot pushed a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants