Address review comments

knative-extensions · Feb 7, 2024 · 9d223c5 · 9d223c5
1 parent 503cee9
commit 9d223c5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...ane/core/src/main/java/dev/knative/eventing/kafka/broker/core/oidc/TokenVerifierImpl.java b/...ane/core/src/main/java/dev/knative/eventing/kafka/broker/core/oidc/TokenVerifierImpl.java
@@ -62,11 +62,11 @@ public Future<JwtClaims> verify(String token, String expectedAudience) {
     public Future<JwtClaims> verify(final HttpServerRequest request, String expectedAudience) {
         String authHeader = request.getHeader("Authorization");
         if (authHeader == null || authHeader.isEmpty()) {
-            return Future.failedFuture("Request didn't contain Authorization header"); // change to exception
+            return Future.failedFuture("Request didn't contain Authorization header");
         }
 
         if (!authHeader.startsWith("Bearer ") && authHeader.length() <= "Bearer ".length()) {
-            return Future.failedFuture("Authorization header didn't contain Bearer token"); // change to exception
+            return Future.failedFuture("Authorization header didn't contain Bearer token");
         }
 
         String token = authHeader.substring("Bearer ".length());

diff --git a/...va/dev/knative/eventing/kafka/broker/receiver/impl/handler/AuthenticationHandlerTest.java b/...va/dev/knative/eventing/kafka/broker/receiver/impl/handler/AuthenticationHandlerTest.java
@@ -82,7 +82,7 @@ public String getAudience() {
     }
 
     @Test
-    public void shouldContinueWithRequestWhenJWTSucceedsFails() {
+    public void shouldContinueWithRequestWhenJWTSucceeds() {
         final HttpServerRequest request = mock(HttpServerRequest.class);
         final var next = mock(Handler.class); // mockHandler(request);