-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ファイル存在チェックの強化 #1727
Merged
Merged
ファイル存在チェックの強化 #1727
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ab89ea3
EPUBMaker: raise ApplicationError instead of RuntimeError
kmuto b8e9f86
PDFMaker: existance check for external files
kmuto 19a02a7
PDFMaker: check coverimage. Closes: #1726
kmuto f80118c
use full_message
kmuto 293a624
Add test against `template_content`
takahashim 0d318da
Update lib/review/pdfmaker.rb
kmuto f9eeac8
for <= Ruby 2.4
kmuto 60f098f
Merge branch 'coverimage-check' into coverimage-check-test
kmuto c5ec433
for Ruby <= 2.4 ver output
kmuto 37145c2
Merge pull request #1729 from kmuto/coverimage-check-test
kmuto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReVIEW::ConfigError
等を拾うのであればApplicationError
でできます(何でもStandardErrorで握りつぶしてしまうのは良くなさそうなので)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERBのbindでエラーが出たときにSyntaxError, ZeroDivisionErrorなど予想がつかない生の例外がきてしまうんですよね。ApplicationErrorで拾えなくて困っています。