patch for MacOSX

[tangxifan]

Hi Kevin,
I have tested the patch on Mac OS Mojave 10.14.4 with AppleClang 10.0.1.10010046.
The example executables argparse_test and argparse_example are working well.
So I try this pull request.

Best regards,
Xifan Tang

[kmurray]

Thanks for the PR Xifan.

Can you clarify why this change is needed? The existing code is valid C++11 (or later), and compiles with GCC (>=4.9) & Clang (>= 3.6).

This library (and VTR) assume C++14 compiler support so it should work. Is it possible that things are not building with C++14 support on Mac?

I'm hesitant to back track on the C++14 support requirement.

[tangxifan]

Hi Kevin, I checked the clang/clang++ version on Mac OS Mojave. It is AppleClang 10.0.1.10010046. The version number is not equivalent with clang version numbers. I tried google it but find nothing useful. That being said, I double checked if —std=c++14 is turned on. The answer is yes. I even tried compiled manually with clang —std=c++14 -c -o. The error message is the same. Therefore, I suspect that AppleClang is a reduced version of Clang, which only supports c++14 partially. In addition, I have tried gcc-4.9, 6, 7, 8 on Mac OS Mojave. But it errors out by a system header file. I googled this and found many complaints. It is a gcc bug while we can not help. All in all, in my opinion, it would be better to be generic in coding to support more OS as well as expand the community of VPR. I can share the travis build log with you and we can discuss further. Maybe a better solution will come up. Best regards, Xifan Tang

…

在 2019年4月9日，下午11:38，kmurray ***@***.***> 写道： Thanks for the PR Xifan. Can you clarify why this change is needed? The existing code is valid C++11 (or later), and compiles with GCC (>=4.9) & Clang (>= 3.6). This library (and VTR) assume C++14 compiler support so it should work. Is it possible that things are not building with C++14 support on Mac? I'm hesitant to back track on the C++14 support requirement. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK95MnqZ29NxZl8zRyKoC5O5aY13rPhpks5vfLQEgaJpZM4cjgH5>.