Added outDir option for pbts #43
Conversation
|
Hey, thanks for the PR. This is definitely something I'd like to support, however I think the functionality needs to be a bit more dynamic - for example, in case of imports with different nesting levels like My first thought is that this option should actually be a function which receives the absolute import path (and possibly the string import name) and returns an output path. I'm not sure if it also makes sense to allow a simple string specifying the root output directory...it seems like there would be ambiguity in the output location for something like Feel free to update this PR with an alternative proposal, or I'll try to draw something up in the coming days. |
|
Yep, that very much covers my case, thanks a lot! I honestly don't think it can be done better, and I would be glad to use that feature in my project. Also, Happy New Year! |
This adds the `output` option to the `pbts` config, which accepts a function to map resource paths (i.e. protobuf file paths) to their typescript declaration (`.d.ts`) paths. This is an alternate approach to #43. --------- Co-authored-by: katel0k <katelkin2003@mail.ru>
|
Great, merged/released. |
While working on my project, I've stumbled upon import issues. I've wanted to declare proto files only in the protos directory outside of my typescript client application. I wanted to have highlightning for typescript files whilst doing
import 'msg.proto'. It didn't work because of include issues in vs code. And importing files viaimport '../some_path/msg.proto'is just ugly. Thus, I've added this option, that allows creating.d.tsfiles in some custom directory instead of the directory with protos