Skip to content

Commit

Permalink
test/fs: enable private-lib in firejail.config
Browse files Browse the repository at this point in the history
Before running test/fs/private-lib.exp.

Inspired by the configuration changes that are done on
test/root/checkcfg.exp.

Reason: Since commit 9741d0b ("fix disabled private-lib in
/etc/firejail/firejail.config", 2022-06-23), the "build_and_test" job
fails with the following error[1]:

    TESTING: private-lib (test/fs/private-lib.exp)
    spawn /bin/bash
    firejail --private-lib --private-bin=sh,bash,dash,ps,grep,ls,find,echo,stty
    runner@fv-az489-993:~/work/firejail/firejail/test/fs$
    <private-bin=sh,bash,dash,ps,grep,ls,find,echo,stty
    Error: private-lib feature is disabled in Firejail configuration file
    runner@fv-az489-993:~/work/firejail/firejail/test/fs$ TESTING ERROR 1

This fixes CI.

Fixes netblue30#5214.

Relates to netblue30#5190.

[1] https://github.com/netblue30/firejail/runs/7030862406
  • Loading branch information
kmk3 committed Jun 24, 2022
1 parent 9741d0b commit 1c7dc8d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/fs/fs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ echo "TESTING: read/write /var/tmp (test/fs/fs_var_tmp.exp)"
rm -f /var/tmp/_firejail_test_file

if [ "$(uname -m)" = "x86_64" ]; then
fjconfig=/etc/firejail/firejail.config
printf 'private-lib yes\n' >> "$fjconfig"
echo "TESTING: private-lib (test/fs/private-lib.exp)"
./private-lib.exp
printf '%s\n' "$(sed '/^private-lib yes$/d' "$fjconfig")" > "$fjconfig"
else
echo "TESTING SKIP: private-lib test implemented only for x86_64."
fi
Expand Down

0 comments on commit 1c7dc8d

Please sign in to comment.