fix verifier log omitted #800
Conversation
Signed-off-by: weli-l <1289113577@qq.com>
pkg/bpf/bpf.go
Outdated
| @@ -79,7 +81,11 @@ func (l *BpfLoader) StartAdsMode() (err error) { | |||
| }() | |||
|
|
|||
| if err = l.obj.Load(); err != nil { | |||
| return fmt.Errorf("bpf Load failed, %s", err) | |||
| l.Stop() | |||
There was a problem hiding this comment.
this is not needed there is a defer above
pkg/bpf/bpf_kmesh_l4_workload.go
Outdated
| } | ||
| }() | ||
|
|
||
| if err = l.obj.Load(); err != nil { | ||
| l.Stop() |
Signed-off-by: weli-l <1289113577@qq.com>
Codecov ReportAttention: Patch coverage is
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -68,6 +69,7 @@ func NewBpfLoader(config *options.BpfConfig) *BpfLoader { | |||
| } | |||
|
|
|||
| func (l *BpfLoader) StartAdsMode() (err error) { | |||
| var ve *ebpf.VerifierError | |||
There was a problem hiding this comment.
This should be var ve ebpf.VerifierError, otherwise the below &ve will panic
There was a problem hiding this comment.
This should be var ve ebpf.VerifierError, otherwise the below &ve will panic
The function we finally call is
func ErrorWithLog(source string, err error, log []byte, truncated bool) *VerifierError {
... ...
}So, this ve should be *ebpf.VerifierError, And actually when I change *ebpf.VerifierError to ebpf.VerifierError, it will panic
There was a problem hiding this comment.
IC, this is related to VerifierError implementation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
fix verifier log omitted
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: