Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dump workload #392

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented May 29, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes part of #214

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.69565% with 42 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 30.85% <8.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/ads/ads_processor.go 79.51% <ø> (ø)
pkg/cache/v2/route.go 50.00% <0.00%> (ø)
pkg/controller/controller.go 0.00% <0.00%> (ø)
pkg/controller/client.go 65.11% <57.14%> (ø)
pkg/controller/workload/cache/workload_cache.go 66.66% <0.00%> (ø)
pkg/status/status_server.go 0.00% <0.00%> (ø)

@nlgwcy
Copy link
Contributor

nlgwcy commented Jun 4, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit c5131d6 into kmesh-net:main Jun 4, 2024
3 checks passed
@hzxuzhonghu hzxuzhonghu deleted the dump-workload branch June 4, 2024 11:15
@hzxuzhonghu hzxuzhonghu changed the title Dump workload Support Dump workload Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants