Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to generated api file under same package #1225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

7h3-3mp7y-m4n
Copy link

What type of PR is this?

Added changes to Makefile to make protobuf generated api file under same package with .proto

/kind bug

What this PR does / why we need it:
This add nessacry change to Makefile to generate the file inside the same directory using protoc --proto_path=. --go_out=. --go_opt=paths=source_relative workloadapi/workload.proto
Which issue(s) this PR fixes:
Fixes #1024

Special notes for your reviewer:
checking to CI because of arm64

Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Feb 6, 2025
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bitcoffeeiux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot
Copy link
Collaborator

Welcome @7h3-3mp7y-m4n! It looks like this is your first PR to kmesh-net/kmesh 🎉

Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
@kmesh-bot kmesh-bot added size/S and removed size/XS labels Feb 6, 2025
@hzxuzhonghu
Copy link
Member

I can run make gen-proto successfully in my AMD64 env.

But it is expected workload.pb.go to be in api/workloadapi/workload.pb.go instead of api/workloadapi/workloadapi/workload.pb.go

@hzxuzhonghu
Copy link
Member

BTW, you can make other protobuf behave same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make protobuf generated api file under same package with .proto
3 participants