Ability to automatically push helm packages at publicize release #1174
Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 43 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
.github/workflows/release.yml
Outdated
| @@ -59,3 +59,5 @@ jobs: | |||
| with: | |||
| files: | | |||
| out/charts/kmesh-helm-${{ github.ref_name }}.tgz | |||
| - name: Push kmesh helm package | |||
| run: make helm-push | |||
There was a problem hiding this comment.
This is not enough, we need to make sure it has logined in
There was a problem hiding this comment.
- name: Login to Github Container Registry
run: echo "${{ secrets.GH_PAT }}" | docker login ghcr.io -u $ --password-stdin
.github/workflows/release.yml
Outdated
| @@ -59,3 +59,5 @@ jobs: | |||
| with: | |||
| files: | | |||
| out/charts/kmesh-helm-${{ github.ref_name }}.tgz | |||
| - name: Push kmesh helm package | |||
| run: make helm-push | |||
There was a problem hiding this comment.
| run: make helm-push | |
| make helm-push CHART_VERSION=${{ github.ref_name }} |
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.0 |
|
@hzxuzhonghu: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hzxuzhonghu: new pull request created: #1175 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
Ability to automatically push helm packages at publicize release.
Add
make helm-pushcomment in workload.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: