Fix bunch of GTK3 issues #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This originates in Fedora: http://bugzilla.redhat.com/show_bug.cgi?id=1231518 I've removed all the wx.VERSION checks. Should (at least partially) fix kliment#897 and kliment#615 Co-authored-by: Scott Talbert <swt@techie.net>
|
Wow, any reason I never saw this patch before? |
|
My lousy work as a packager. I should have proposed it right away back then, but somehow I haven't 😞 |
|
Tested it, print flow setting looks weird, otherwise huge improvement. Though I still don't really understand why the gtk people thought that making that change to the spinctrl was a good idea. Now I need to see whether it looks sane on other platforms. |
|
|
|
Confirmed.
|
|
added a fixup commit:
|
|
Fix confirmed, testing on windows now |
|
Works on windows too |
|
I could have squashed the fixup, but whatever :) |
|
BTW on macOS:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originates in Fedora: http://bugzilla.redhat.com/show_bug.cgi?id=1231518
I've removed all the
wx.VERSIONchecks.Should (at least partially) fix #897 and #615
Co-authored-by: Scott Talbert swt@techie.net